Bug 1277 - sr_packet_copy() and sr_packet_free() are private.
Summary: sr_packet_copy() and sr_packet_free() are private.
Status: RESOLVED FIXED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: API (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-09 11:25 CEST by Martin Ling
Modified: 2018-09-18 23:57 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Ling 2018-09-09 11:25:08 CEST 
It's not clear to me why these functions are private.

The clear use case for them is to allow a client to keep copy of a packet that was passed to its datafeed callback on the stack, and then free it later.

They're not used internally at all, and never have been.

We would need them public to fix bug #994 in the bindings.
Comment 1 Uwe Hermann 2018-09-18 23:57:32 CEST 
Fixed in 3bae09ab9fc3681e0ae3d2f16e862c831d43efc3, thanks!