Bug 1154 - Logic channel state not considered during acquisition
Summary: Logic channel state not considered during acquisition
Status: IN_PROGRESS
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Driver: demo (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal major
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-08 23:01 CEST by Soeren Apel
Modified: 2018-10-11 13:29 CEST (History)
1 user (show)


Attachments
disabled_channels (95.61 KB, image/png)
2018-10-11 13:29 CEST, stegu13 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2018-04-08 23:01:56 CEST 
When all 8 logic channels are enabled, demo returns the expected data. However, disabling logic channels before running the acquisition causes the driver to produce wrong output data.

Example:
-) Start PV
-) Disable all logic channels except for one
-) Run acquisition
-) Notice that the logic data ends up on D0, regardless of which channel you enabled
Comment 1 stegu13 2018-10-11 12:02:29 CEST 
I addressed logic channel map in part of this commit: https://github.com/luftek/libsigrok/commit/b77810ba5c0c6c2ee7873084ebce1ff9a063e7d8

Will investigate how to rebase this changes.
Comment 2 stegu13 2018-10-11 13:29:09 CEST 
Created attachment 469 [details]
disabled_channels

In case of disabling in example channels D2-D5, data is not generated for D0-D7. It is generated for D0-D4.
Data should be generated for highest index from all enabled channels.