Bug 1120 - Setting timebase to a nanosecond value crashes
Summary: Setting timebase to a nanosecond value crashes
Status: RESOLVED FIXED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Driver: siglent-sds (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: marchelh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-18 17:25 CET by Uwe Hermann
Modified: 2018-03-03 18:47 CET (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2018-02-18 17:25:01 CET 
Setting the timebase to MS or S works fine, setting to any NS value crashes. It's unclear why this happens, needs investigation.
Comment 1 marchelh 2018-02-18 18:58:42 CET 
Problem is one 0 to short on the ns case at line 702
was: 	case 100000000:
must be:  case 1000000000:

When changed it is working
Comment 2 Gerhard Sittig 2018-02-19 07:26:46 CET 
Are there two issues? A missing 0 which made the setting not take effect. 
And a missing 'default' case which had prevented the crash?
Comment 3 Uwe Hermann 2018-03-03 18:47:40 CET 
Fixed in 80eba3857a61931793054f95e6b8c7eac8e3a7fe, thanks!