Bug 454

Summary: Unit tests need update to new sr C++ bindings based code
Product: PulseView Reporter: Uwe Hermann <uwe>
Component: Unit testsAssignee: Nobody <nobody>
Status: CONFIRMED ---    
Severity: normal CC: joel, soeren
Priority: Normal    
Version: unreleased development snapshot   
Target Milestone: ---   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 366    

Description Uwe Hermann 2014-10-19 19:29:43 CEST
The PulseView unit tests (-DENABLE_TESTS=y) need an update:

[ 57%] Built target pulseview
[ 58%] Building CXX object test/CMakeFiles/pulseview-test.dir/data/logicsnapshot.cpp.o
[...]/pulseview/test/data/logicsnapshot.cpp: In function ‘void LogicSnapshotTest::push_logic(pv::data::LogicSnapshot&, unsigned int, uint8_t)’: 
[...]/pulseview/test/data/logicsnapshot.cpp:36:2: error: ‘sr_datafeed_logic’ was not declared in this scope
  sr_datafeed_logic logic;
  ^
[...]/pulseview/test/data/logicsnapshot.cpp:37:2: error: ‘logic’ was not declared in this scope
  logic.unitsize = 1;
  ^
[...]/pulseview/test/data/logicsnapshot.cpp: In member function ‘void LogicSnapshotTest::Basic::test_method()’:
[...]/pulseview/test/data/logicsnapshot.cpp:65:2: error: ‘sr_datafeed_logic’ was not declared in this scope
  sr_datafeed_logic logic;
  ^
[...]/pulseview/test/data/logicsnapshot.cpp:66:2: error: ‘logic’ was not declared in this scope
  logic.length = 0;
  ^
[...]/pulseview/test/data/logicsnapshot.cpp: In member function ‘void LogicSnapshotTest::LargeData::test_method()’:
[...]/pulseview/test/data/logicsnapshot.cpp:161:2: error: ‘sr_datafeed_logic’ was not declared in this scope
  sr_datafeed_logic logic;
  ^
Comment 1 Uwe Hermann 2015-09-23 15:43:17 CEST
Drop 0.3.0 milestone. This is nice to have fixed, but not a hard requirement for the 0.3.0 release.