Bug 38

Summary: Fallback icons are only provided in size 22x22, but 16x16 icons are needed for menu items
Product: PulseView Reporter: Joel Holdsworth <joel>
Component: OtherAssignee: Nobody <nobody>
Status: CONFIRMED ---    
Severity: normal CC: martin-sigrokbugs, uwe
Priority: Normal    
Version: unreleased development snapshot   
Target Milestone: ---   
Hardware: x86   
OS: Linux   
Attachments: Windows

Description Joel Holdsworth 2013-01-15 20:38:56 CET
Qt will try and deal with this by downscaling the 22x22 icons for menus, but it will look blurry. Small icons alway need to be hand adjusted so that they are pixel-perfect.

This does not apply when XDG icons are being used - only when the fallback is in use i.e. on Windows.
Comment 1 Martin Ling 2017-05-10 17:20:10 CEST
This is the oldest open bug in sigrok.

Is this still relevant now that PulseView doesn't have a traditional menu bar any more?
Comment 2 Uwe Hermann 2017-05-11 01:03:06 CEST
Yup, icons in general are still relevant, I think. E.g. for high-DPI displays and for use in other places differently-sized icons (or SVG icons if possible) should be provided.

Example: QT_SCALE_FACTOR=4 ./pulseview

All icons should ideally not look too pixelated in something like that, otherwise it's probably an indication that differently-sized or scalable ones should be used, I think.
Comment 3 Uwe Hermann 2017-05-11 01:22:48 CEST
Created attachment 302 [details]
Comment 4 Uwe Hermann 2017-05-11 01:23:18 CEST
Created attachment 303 [details]
Comment 5 Uwe Hermann 2017-05-11 01:23:32 CEST
Created attachment 304 [details]
Comment 6 Uwe Hermann 2017-05-11 01:23:45 CEST
Created attachment 305 [details]
Comment 7 Uwe Hermann 2017-05-11 01:25:03 CEST
I've attached a few screenshot with QT_SCALE_FACTOR=4 with various X11 XDG themes and a Windows screenshot for comparison. Not sure how much can be improved there.

Too much hassle to do *BSD, Android, Mac OS X right now, but I expect some more variations there.
Comment 8 Martin Ling 2017-05-11 01:46:59 CEST
Right but do we still need 16x16 raster versions as per the original report? The suggestion was that those were only needed for menus.

Actually why are we even getting pixellated icons in those screenshots? Most of those icons are SVGs,