From: Gerhard Sittig <redacted>
Date: Sat, 16 May 2020 16:07:37 +0000 (+0200)
Subject: asix-sigma: more trigger spec to register values conversion sync with doc
X-Git-Url: http://sigrok.org/gitweb/?p=libsigrok.git;a=commitdiff_plain;h=16791da9c98d56453a31dee9062fad8a08279181

asix-sigma: more trigger spec to register values conversion sync with doc

Rephrase more parts of sigma_build_basic_trigger() to closer match the
vendor documentation. Use the M3Q name. Be explicit about "parameters"
setup (even if that means to assign zero values, comments help there).
Using three BE16 items for the parameters improves readability.
---

diff --git a/src/hardware/asix-sigma/protocol.c b/src/hardware/asix-sigma/protocol.c
index 6051c6b7..9b61fd56 100644
--- a/src/hardware/asix-sigma/protocol.c
+++ b/src/hardware/asix-sigma/protocol.c
@@ -435,7 +435,8 @@ SR_PRIV int sigma_write_trigger_lut(struct dev_context *devc,
 	int lut_addr;
 	uint16_t bit;
 	uint8_t m3d, m2d, m1d, m0d;
-	uint8_t buf[6], *wrptr, regval;
+	uint8_t buf[6], *wrptr;
+	uint16_t selreg;
 	int ret;
 
 	/*
@@ -453,7 +454,7 @@ SR_PRIV int sigma_write_trigger_lut(struct dev_context *devc,
 			m3d |= 1 << 2;
 		if (lut->m3s & bit)
 			m3d |= 1 << 1;
-		if (lut->m3 & bit)
+		if (lut->m3q & bit)
 			m3d |= 1 << 0;
 
 		/* M2D3 M2D2 M2D1 M2D0 */
@@ -513,16 +514,14 @@ SR_PRIV int sigma_write_trigger_lut(struct dev_context *devc,
 	 * Send the parameters. This covers counters and durations.
 	 */
 	wrptr = buf;
-	regval = 0;
-	regval |= (lut->params.selc & TRGSEL_SELC_MASK) << TRGSEL_SELC_SHIFT;
-	regval |= (lut->params.selpresc & TRGSEL_SELPRESC_MASK) << TRGSEL_SELPRESC_SHIFT;
-	write_u8_inc(&wrptr, regval);
-	regval = 0;
-	regval |= (lut->params.selinc & TRGSEL_SELINC_MASK) << TRGSEL_SELINC_SHIFT;
-	regval |= (lut->params.selres & TRGSEL_SELRES_MASK) << TRGSEL_SELRES_SHIFT;
-	regval |= (lut->params.sela & TRGSEL_SELA_MASK) << TRGSEL_SELA_SHIFT;
-	regval |= (lut->params.selb & TRGSEL_SELB_MASK) << TRGSEL_SELB_SHIFT;
-	write_u8_inc(&wrptr, regval);
+	selreg = 0;
+	selreg |= (lut->params.selinc & TRGSEL_SELINC_MASK) << TRGSEL_SELINC_SHIFT;
+	selreg |= (lut->params.selres & TRGSEL_SELRES_MASK) << TRGSEL_SELRES_SHIFT;
+	selreg |= (lut->params.sela & TRGSEL_SELA_MASK) << TRGSEL_SELA_SHIFT;
+	selreg |= (lut->params.selb & TRGSEL_SELB_MASK) << TRGSEL_SELB_SHIFT;
+	selreg |= (lut->params.selc & TRGSEL_SELC_MASK) << TRGSEL_SELC_SHIFT;
+	selreg |= (lut->params.selpresc & TRGSEL_SELPRESC_MASK) << TRGSEL_SELPRESC_SHIFT;
+	write_u16be_inc(&wrptr, selreg);
 	write_u16be_inc(&wrptr, lut->params.cmpb);
 	write_u16be_inc(&wrptr, lut->params.cmpa);
 	ret = sigma_write_register(devc, WRITE_TRIGGER_SELECT, buf, wrptr - buf);
@@ -1870,7 +1869,7 @@ SR_PRIV int sigma_build_basic_trigger(struct dev_context *devc,
 	/* Start assuming simple triggers. */
 	memset(lut, 0, sizeof(*lut));
 	lut->m4 = 0xa000;
-	lut->m3 = 0xffff;
+	lut->m3q = 0xffff;
 
 	/* Process value/mask triggers. */
 	value = devc->trigger.simplevalue;
@@ -1896,19 +1895,22 @@ SR_PRIV int sigma_build_basic_trigger(struct dev_context *devc,
 
 	/* Add glue logic for rise/fall triggers. */
 	if (masks[0] || masks[1]) {
-		lut->m3 = 0;
+		lut->m3q = 0;
 		if (masks[0] & devc->trigger.risingmask)
-			add_trigger_function(OP_RISE, FUNC_OR, 0, 0, &lut->m3);
+			add_trigger_function(OP_RISE, FUNC_OR, 0, 0, &lut->m3q);
 		if (masks[0] & devc->trigger.fallingmask)
-			add_trigger_function(OP_FALL, FUNC_OR, 0, 0, &lut->m3);
+			add_trigger_function(OP_FALL, FUNC_OR, 0, 0, &lut->m3q);
 		if (masks[1] & devc->trigger.risingmask)
-			add_trigger_function(OP_RISE, FUNC_OR, 1, 0, &lut->m3);
+			add_trigger_function(OP_RISE, FUNC_OR, 1, 0, &lut->m3q);
 		if (masks[1] & devc->trigger.fallingmask)
-			add_trigger_function(OP_FALL, FUNC_OR, 1, 0, &lut->m3);
+			add_trigger_function(OP_FALL, FUNC_OR, 1, 0, &lut->m3q);
 	}
 
 	/* Triggertype: event. */
-	lut->params.selres = 3;
+	lut->params.selres = TRGSEL_SELCODE_NEVER;
+	lut->params.selinc = TRGSEL_SELCODE_LEVEL;
+	lut->params.sela = 0; /* Counter >= CMPA && LEVEL */
+	lut->params.cmpa = 0; /* Count 0 -> 1 already triggers. */
 
 	return SR_OK;
 }
diff --git a/src/hardware/asix-sigma/protocol.h b/src/hardware/asix-sigma/protocol.h
index 507088c0..1311c935 100644
--- a/src/hardware/asix-sigma/protocol.h
+++ b/src/hardware/asix-sigma/protocol.h
@@ -129,10 +129,6 @@ enum sigma_read_register {
 
 #define BIT_MASK(l)	((1UL << (l)) - 1)
 
-#define TRGSEL_SELC_MASK	BIT_MASK(2)
-#define TRGSEL_SELC_SHIFT	0
-#define TRGSEL_SELPRESC_MASK	BIT_MASK(4)
-#define TRGSEL_SELPRESC_SHIFT	4
 #define TRGSEL_SELINC_MASK	BIT_MASK(2)
 #define TRGSEL_SELINC_SHIFT	0
 #define TRGSEL_SELRES_MASK	BIT_MASK(2)
@@ -141,6 +137,18 @@ enum sigma_read_register {
 #define TRGSEL_SELA_SHIFT	4
 #define TRGSEL_SELB_MASK	BIT_MASK(2)
 #define TRGSEL_SELB_SHIFT	6
+#define TRGSEL_SELC_MASK	BIT_MASK(2)
+#define TRGSEL_SELC_SHIFT	8
+#define TRGSEL_SELPRESC_MASK	BIT_MASK(4)
+#define TRGSEL_SELPRESC_SHIFT	12
+
+enum trgsel_selcode_t {
+	TRGSEL_SELCODE_LEVEL = 0,
+	TRGSEL_SELCODE_FALL = 1,
+	TRGSEL_SELCODE_RISE = 2,
+	TRGSEL_SELCODE_EVENT = 3,
+	TRGSEL_SELCODE_NEVER = 3,
+};
 
 #define TRGSEL2_PINS_MASK	(0x07 << 0)
 #define TRGSEL2_PINPOL_RISE	(1 << 3)
@@ -259,7 +267,7 @@ struct triggerinout {
 struct triggerlut {
 	/* The actual LUTs. */
 	uint16_t m0d[4], m1d[4], m2d[4];
-	uint16_t m3, m3s, m4;
+	uint16_t m3q, m3s, m4;
 
 	/* Parameters should be sent as a single register write. */
 	struct {