From: Gerhard Sittig <redacted>
Date: Sun, 2 Aug 2020 18:14:13 +0000 (+0200)
Subject: avr_isp: move "unknown command" to warning, drop empty 'bits' row
X-Git-Url: http://sigrok.org/gitweb/?a=commitdiff_plain;ds=sidebyside;h=3f2a461681e5462e3917ddba7fb5e9ae7e31f29b;hp=f5250c609e0abaaee3ae0eb46b271568ac2a82b9;p=libsigrokdecode.git

avr_isp: move "unknown command" to warning, drop empty 'bits' row

Use the warnings annotation class for the "Unknown command" message, the
PE class (programming enabled) is unexpected and most probably a typo.

Drop the empty 'bits' annotation row which has been unused since commit
3b0013416fcfb.
---

diff --git a/decoders/avr_isp/pd.py b/decoders/avr_isp/pd.py
index 5a76a9d..31dd841 100644
--- a/decoders/avr_isp/pd.py
+++ b/decoders/avr_isp/pd.py
@@ -49,7 +49,6 @@ class Decoder(srd.Decoder):
         ('dev', 'Device'),
     )
     annotation_rows = (
-        ('bits', 'Bits', ()),
         ('commands', 'Commands', (Ann.PE, Ann.RSB0, Ann.RSB1, Ann.RSB2,
             Ann.CE, Ann.RFB, Ann.RHFB, Ann.REFB,)),
         ('warnings', 'Warnings', (Ann.WARN,)),
@@ -182,7 +181,7 @@ class Decoder(srd.Decoder):
         else:
             c = '%02x %02x %02x %02x' % tuple(cmd)
             r = '%02x %02x %02x %02x' % tuple(ret)
-            self.putx([Ann.PE, ['Unknown command: %s (reply: %s)!' % (c, r)]])
+            self.putx([Ann.WARN, ['Unknown command: %s (reply: %s)!' % (c, r)]])
 
     def decode(self, ss, es, data):
         ptype, mosi, miso = data