X-Git-Url: http://sigrok.org/gitweb/?a=blobdiff_plain;f=src%2Finput%2Fcsv.c;h=3a42fc9b1e6cfd1d479bb7f9de72643f862e759f;hb=bfc34b9ab0302fa0ba98eef3ce1b35c76d378589;hp=d6501ed99fc06d0c6b5ce44c7b5f3b8d0c3cff4a;hpb=811dcf7ea95384b0450d475699d3c20203d02132;p=libsigrok.git diff --git a/src/input/csv.c b/src/input/csv.c index d6501ed9..3a42fc9b 100644 --- a/src/input/csv.c +++ b/src/input/csv.c @@ -350,6 +350,7 @@ static int flush_logic_samples(const struct sr_input *in) return rc; inc->datafeed_buf_fill = 0; + return SR_OK; } @@ -368,6 +369,7 @@ static int queue_logic_samples(const struct sr_input *in) if (rc != SR_OK) return rc; } + return SR_OK; } @@ -443,6 +445,7 @@ static int flush_analog_samples(const struct sr_input *in) } inc->analog_datafeed_buf_fill = 0; + return SR_OK; } @@ -461,6 +464,7 @@ static int queue_analog_samples(const struct sr_input *in) if (rc != SR_OK) return rc; } + return SR_OK; } @@ -728,6 +732,7 @@ static const struct column_details *lookup_column_details(struct context *inc, s return NULL; if (!nr || nr > inc->column_want_count) return NULL; + return &inc->column_details[nr - 1]; } @@ -751,7 +756,7 @@ static void strip_comment(char *buf, const GString *prefix) } /** - * @brief Splits a text line into a set of columns. + * Splits a text line into a set of columns. * * @param[in] buf The input text line to split. * @param[in] inc The input module's context. @@ -766,7 +771,7 @@ static char **split_line(char *buf, struct context *inc) } /** - * @brief Parse a multi-bit field into several logic channels. + * Parse a multi-bit field into several logic channels. * * @param[in] column The input text, a run of bin/hex/oct digits. * @param[in] inc The input module's context. @@ -876,7 +881,7 @@ static int parse_logic(const char *column, struct context *inc, } /** - * @brief Parse a floating point text into an analog value. + * Parse a floating point text into an analog value. * * @param[in] column The input text, a floating point number. * @param[in] inc The input module's context. @@ -925,7 +930,7 @@ static int parse_analog(const char *column, struct context *inc, } /** - * @brief Parse a timestamp text, auto-determine samplerate. + * Parse a timestamp text, auto-determine samplerate. * * @param[in] column The input text, a floating point number. * @param[in] inc The input module's context. @@ -1014,7 +1019,7 @@ static int parse_timestamp(const char *column, struct context *inc, } /** - * @brief Parse routine which ignores the input text. + * Parse routine which ignores the input text. * * This routine exists to unify dispatch code paths, mapping input file * columns' data types to their respective parse routines. @@ -1025,6 +1030,7 @@ static int parse_ignore(const char *column, struct context *inc, (void)column; (void)inc; (void)details; + return SR_OK; } @@ -1156,6 +1162,7 @@ static int format_match(GHashTable *metadata, unsigned int *confidence) if (!status) return SR_ERR; + return SR_OK; } @@ -1388,7 +1395,7 @@ static int initial_parse(const struct sr_input *in, GString *buf) ret = SR_ERR; goto out; } - sr_dbg("DIAG Got %zu columns in text line: %s.", num_columns, line); + sr_dbg("Got %zu columns in text line: %s.", num_columns, line); /* * Interpret the user provided column format specs. This might @@ -1788,7 +1795,7 @@ static struct sr_option options[] = { }, [OPT_HEADER] = { "header", "Get channel names from first line.", - "Use the first processed line's column captions (when available) as channel names. Off by default", + "Use the first processed line's column captions (when available) as channel names. Enabled by default.", NULL, NULL, }, [OPT_SAMPLERATE] = { @@ -1825,7 +1832,7 @@ static const struct sr_option *get_options(void) l = g_slist_append(l, g_variant_ref_sink(g_variant_new_string("oct"))); options[OPT_SINGLE_FMT].values = l; options[OPT_START_LINE].def = g_variant_ref_sink(g_variant_new_uint32(1)); - options[OPT_HEADER].def = g_variant_ref_sink(g_variant_new_boolean(FALSE)); + options[OPT_HEADER].def = g_variant_ref_sink(g_variant_new_boolean(TRUE)); options[OPT_SAMPLERATE].def = g_variant_ref_sink(g_variant_new_uint64(0)); options[OPT_COL_SEP].def = g_variant_ref_sink(g_variant_new_string(",")); options[OPT_COMMENT].def = g_variant_ref_sink(g_variant_new_string(";"));