X-Git-Url: http://sigrok.org/gitweb/?a=blobdiff_plain;f=hwdriver.c;h=c0381432a2dd94ef75b6815d427ef71a17f5ad3a;hb=50985c2019b2b5a6ce394589d89ee925b4f5e3a9;hp=b8726e8c887e98568db01e4b893e27e620848f62;hpb=3864648bb6ebf24106898a1296bc106daa55e964;p=libsigrok.git diff --git a/hwdriver.c b/hwdriver.c index b8726e8c..c0381432 100644 --- a/hwdriver.c +++ b/hwdriver.c @@ -1,7 +1,7 @@ /* - * This file is part of the sigrok project. + * This file is part of the libsigrok project. * - * Copyright (C) 2010-2012 Bert Vermeulen + * Copyright (C) 2013 Bert Vermeulen * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -61,6 +61,8 @@ static struct sr_config_info sr_config_info_data[] = { "Pre-trigger capture ratio", NULL}, {SR_CONF_PATTERN_MODE, SR_T_CHAR, "pattern", "Pattern generator mode", NULL}, + {SR_CONF_TRIGGER_TYPE, SR_T_CHAR, "triggertype", + "Trigger types", NULL}, {SR_CONF_RLE, SR_T_BOOL, "rle", "Run Length Encoding", NULL}, {SR_CONF_TRIGGER_SLOPE, SR_T_UINT64, "triggerslope", @@ -355,26 +357,45 @@ SR_PRIV void sr_hw_cleanup_all(void) } } -SR_PRIV struct sr_config *sr_config_make(int key, const void *value) +/** A floating reference can be passed in for data. */ +SR_PRIV struct sr_config *sr_config_new(int key, GVariant *data) { struct sr_config *src; if (!(src = g_try_malloc(sizeof(struct sr_config)))) return NULL; src->key = key; - src->value = value; + src->data = g_variant_ref_sink(data); return src; } +SR_PRIV void sr_config_free(struct sr_config *src) +{ + + if (!src || !src->data) { + sr_err("%s: invalid data!", __func__); + return; + } + + g_variant_unref(src->data); + g_free(src); + +} + /** * Returns information about the given driver or device instance. * * @param driver The sr_dev_driver struct to query. * @param key The configuration key (SR_CONF_*). - * @param data Pointer where the value will be stored. Must not be NULL. - * @param sdi If the key is specific to a device, this must contain a - * pointer to the struct sr_dev_inst to be checked. + * @param data Pointer to a GVariant where the value will be stored. Must + * not be NULL. The caller is given ownership of the GVariant + * and must thus decrease the refcount after use. However if + * this function returns an error code, the field should be + * considered unused, and should not be unreferenced. + * @param sdi (optional) If the key is specific to a device, this must + * contain a pointer to the struct sr_dev_inst to be checked. + * Otherwise it must be NULL. * * @return SR_OK upon success or SR_ERR in case of error. Note SR_ERR_ARG * may be returned by the driver indicating it doesn't know that key, @@ -382,14 +403,21 @@ SR_PRIV struct sr_config *sr_config_make(int key, const void *value) * as an indication that it's not applicable. */ SR_API int sr_config_get(const struct sr_dev_driver *driver, int key, - const void **data, const struct sr_dev_inst *sdi) + GVariant **data, const struct sr_dev_inst *sdi) { int ret; if (!driver || !data) return SR_ERR; - ret = driver->config_get(key, data, sdi); + if (!driver->config_get) + return SR_ERR_ARG; + + if ((ret = driver->config_get(key, data, sdi)) == SR_OK) { + /* Got a floating reference from the driver. Sink it here, + * caller will need to unref when done with it. */ + g_variant_ref_sink(*data); + } return ret; } @@ -399,26 +427,29 @@ SR_API int sr_config_get(const struct sr_dev_driver *driver, int key, * * @param sdi The device instance. * @param key The configuration key (SR_CONF_*). - * @param value The new value for the key, as a pointer to whatever type - * is appropriate for that key. + * @param data The new value for the key, as a GVariant with GVariantType + * appropriate to that key. A floating reference can be passed + * in; its refcount will be sunk and unreferenced after use. * * @return SR_OK upon success or SR_ERR in case of error. Note SR_ERR_ARG * may be returned by the driver indicating it doesn't know that key, * but this is not to be flagged as an error by the caller; merely * as an indication that it's not applicable. */ -SR_API int sr_config_set(const struct sr_dev_inst *sdi, int key, - const void *value) +SR_API int sr_config_set(const struct sr_dev_inst *sdi, int key, GVariant *data) { int ret; - if (!sdi || !sdi->driver || !value) - return SR_ERR; + g_variant_ref_sink(data); - if (!sdi->driver->config_set) - return SR_ERR_ARG; + if (!sdi || !sdi->driver || !data) + ret = SR_ERR; + else if (!sdi->driver->config_set) + ret = SR_ERR_ARG; + else + ret = sdi->driver->config_set(key, data, sdi); - ret = sdi->driver->config_set(key, value, sdi); + g_variant_unref(data); return ret; } @@ -428,10 +459,13 @@ SR_API int sr_config_set(const struct sr_dev_inst *sdi, int key, * * @param driver The sr_dev_driver struct to query. * @param key The configuration key (SR_CONF_*). - * @param data A pointer to a list of values, in whatever format is - * appropriate for that key. - * @param sdi If the key is specific to a device, this must contain a - * pointer to the struct sr_dev_inst to be checked. + * @param data A pointer to a GVariant where the list will be stored. The + * caller is given ownership of the GVariant and must thus + * unref the GVariant after use. However if this function + * returns an error code, the field should be considered + * unused, and should not be unreferenced. + * @param sdi (optional) If the key is specific to a device, this must + * contain a pointer to the struct sr_dev_inst to be checked. * * @return SR_OK upon success or SR_ERR in case of error. Note SR_ERR_ARG * may be returned by the driver indicating it doesn't know that key, @@ -439,14 +473,16 @@ SR_API int sr_config_set(const struct sr_dev_inst *sdi, int key, * as an indication that it's not applicable. */ SR_API int sr_config_list(const struct sr_dev_driver *driver, int key, - const void **data, const struct sr_dev_inst *sdi) + GVariant **data, const struct sr_dev_inst *sdi) { int ret; if (!driver || !data) - return SR_ERR; - - ret = driver->config_list(key, data, sdi); + ret = SR_ERR; + else if (!driver->config_list) + ret = SR_ERR_ARG; + else if ((ret = driver->config_list(key, data, sdi)) == SR_OK) + g_variant_ref_sink(*data); return ret; } @@ -454,7 +490,7 @@ SR_API int sr_config_list(const struct sr_dev_driver *driver, int key, /** * Get information about a configuration key. * - * @param opt The configuration key. + * @param key The configuration key. * * @return A pointer to a struct sr_config_info, or NULL if the key * was not found.