| Summary: | Corrupted timescale shown when zooming out (max) and then in (max) | ||
|---|---|---|---|
| Product: | PulseView | Reporter: | Uwe Hermann <uwe> |
| Component: | Data display | Assignee: | Nobody <nobody> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | soeren |
| Priority: | Normal | ||
| Version: | unreleased development snapshot | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Screenshot of zoom issue | ||
The issue here is that several variables dealing with floating-point time values using doubles are losing their precision. The large view offset caused by zooming out doesn't leave enough bits to represent the fractional part with the precision that we need. As a result, calculations go haywire. This is something that has no short-term fix, so I went ahead and limited the max zoom level to 100 ps, where everything works well as long as the measurement isn't much longer than about 24 hours. I think that's a plausible compromise. Looking into this also revealed a subtle bug in the time formatting algorithm that is now fixed. Thanks, the short-term fix is merged as 818f617924d2ed393cadd362fdafbd9d4288848f. The other unrelated fix you mentioned is merged as ca810a8ce1f0257e78ad00bc8f794c68f7438cad. Leaving the bug open though since the issue is not entirely fixed, yet. Fully fixed in 60d9b99a32e551cffd2b537d3e157d578a761c9b, thanks! |
Created attachment 148 [details] Screenshot of zoom issue PulseView shows a corrupted timescale (see attached screenshot). How to reproduce: - Start PV, no devices attached, demo is autoselected. - Use the scrollwheel to zoom out until you cannot zoom further. - Use the scrollwheel to zoom in until you cannot zoom further. When zooming in the timescale will eventually corrupt. This is reproducible on Linux with Qt5 and on Windows with Qt4 so I'm somewhat confident that it isn't my specific system or window manager or something like that.