Summary: | Many functions should take a context pointer and don't. | ||
---|---|---|---|
Product: | libsigrok | Reporter: | Martin Ling <martin-sigrokbugs> |
Component: | API | Assignee: | Nobody <nobody> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | daniel.kitta |
Priority: | Normal | ||
Version: | unreleased development snapshot | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Martin Ling
2015-03-25 22:01:06 CET
In the current code base, the functions sr_driver_list(), sr_session_load() and sr_session_new() already take an sr_context. Wrt the sr_log_*() functions from your list, I don't think it's worth the effort. One would have to convert all calls to sr_err(), sr_warn(), sr_info(), etc. to take a context argument, which would be really painful. I'm not aware of any other library which does something like this for its logging functions. |