Summary: | After loading a file, a "Zoom to Fit" should be done | ||
---|---|---|---|
Product: | PulseView | Reporter: | Ulfl <ulf.lamping> |
Component: | Data display | Assignee: | Nobody <nobody> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | joel, soeren, uwe |
Priority: | Normal | ||
Version: | unreleased development snapshot | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Ulfl
2014-01-01 19:46:42 CET
To properly solve this, we need to zoom-fit before all the data arrives. It's no good doing it afterward - a large file could take 30s to load, and the user may be inspecting something. The problem then is how to find out the length of the file before it's completely loaded? Is there some way this could be exposed in the new sigrok API. Certainly with the proposed new file format we would know the length. Do we know it already with the current file format? Note: while not a fix for this bug it's worth mentioning that you can now press the "zoom to fit" button while the file is loading and it will continue fitting all samples on screen until the file is fully loaded. Also, an issue I'm seeing here is that there's no guarantee that we *always* know the length of the data upfront. It may be doable for srzip or the future file format but for others, this may be impossible. This will cause confusion as a future "zoom to fit after loading" function works for some file formats and not others, so it needs careful integration. Fixed in 28ceff251c776bcf99eafae691e70a521af15957, thanks! |