Summary: | Rigol-ds only calculates a valid sample rate if at least one analog channel is enabled | ||
---|---|---|---|
Product: | libsigrok | Reporter: | John Sanderson <john> |
Component: | Driver: rigol-ds | Assignee: | Nobody <nobody> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | morten, philippschmid2, soeren, uwe |
Priority: | Normal | ||
Version: | unreleased development snapshot | ||
Target Milestone: | --- | ||
Hardware: | x86 | ||
OS: | All | ||
Attachments: |
.sr
screen shot .sr second try |
Description
John Sanderson
2017-12-15 18:08:00 CET
Hello John, can you please provide a) an .sr file of the data you measured and b) a screenshot of what PV looks like (ideally with the decoder config dialog open) Thanks! (In reply to Soeren Apel from comment #1) > Hello John, can you please provide > a) an .sr file of the data you measured and > b) a screenshot of what PV looks like (ideally with the decoder config > dialog open) > > Thanks! Hi Soeren! That's quick! I'll tfr this and present it soon. rgds, John Created attachment 355 [details]
.sr
Created attachment 356 [details]
screen shot
Hi Soeren, As requested. Hope it helps... rgds, John Thanks! The samplerate in the .sr file is 0 Hz, that causes the problems later on. We need to fix whatever place doesn't properly pass along the samplerate, maybe the rigol-ds driver in libsigrok (just a guess at the moment). I've faked the samplerate to 1MHz for a quick test, the I2C decoder is running OK then (didn't check the data, though). Hi Soeren, Thanks, at least there's a sane answer. I have seen that my screen is not the same as shown in the various tutorials, videos and so on but I don't know why. Is there a way for me to adjust the sample rate? (haven't seen it yet..) rgds, John Created attachment 357 [details]
.sr second try
This is a second trial .sr file.
It includes the I2C trace which the first file did not have.
This is a driver bug. As we can see, the driver only calculates a valid sample rate if at least one analog channel is enabled: https://sigrok.org/gitweb/?p=libsigrok.git;a=blob;f=src/hardware/rigol-ds/api.c;h=443d89ddc7166e95e39e71eefba9b16bcfc376ff;hb=HEAD#l521 John's screenshot shows that he has both analog channels disabled, which triggers this bug. Soeren and Uwe! Thanks, you were dead right. Not what was intended but it's great to now have a workaround! rgds, John Parts of this is fixed in libsigrokdecode now (e.g. in 8accc30bf5d98aa958af839511d57e0e1ddefe94), many decoders now will work fine without samplerate as well (where possible). Leaving the bug open, as there's still a driver bug there, of course. *** Bug 1495 has been marked as a duplicate of this bug. *** |